Add sanitizer support using GCC toolchain features by RSingh1511 · Pull Request #64 · eclipse-score/logging

RSingh1511 · 2026-02-16T04:04:28Z

Notes for Reviewer

Pre-Review Checklist for the PR Author

PR title is short, expressive and meaningful
Commits are properly organized
Relevant issues are linked in the References section
Tests are conducted
Unit tests are added

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes #

github-actions · 2026-02-16T04:05:04Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
2026/02/25 11:37:35 Downloading https://releases.bazel.build/8.3.0/release/bazel-8.3.0-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: de883a33-efe2-4444-8866-1fab76b8b393
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_rust', the root module requires module version rules_rust@0.61.0, but got rules_rust@0.67.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.16 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@2.0.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 10.048s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

github-actions · 2026-02-16T04:07:49Z

The created documentation from the pull request is available at: docu-html

MaximilianSoerenPollak · 2026-02-16T11:31:22Z

MODULE.bazel

 bazel_dep(name = "score_bazel_platforms", version = "0.0.4")
-bazel_dep(name = "score_docs_as_code", version = "2.2.0")
-bazel_dep(name = "score_tooling", version = "1.1.1")
+bazel_dep(name = "score_docs_as_code", version = "2.3.0")


You will need docs-as-code 3.0.1 if you want to use tooling 1.1.2.

I've verified that score_docs_as_code@2.3.0 works correctly with score_tooling@1.1.2 and all tests pass. The sanitizer implementation is complete and ready for review.

Using 3.0.1 causes CI failures because score_tooling@1.1.2 declares it as dev_dependency = True, making it invisible to consuming modules.

Do you need the new added Documentation API this from tooling 1.1.2?
If not then downgrading to 1.1.0 and upgrading docs-as-code to 3.0.0 would be advisable.
Otherwise you will not be able to use the new features from docs-as-code.
See Features Here

Done! Downgraded to score_tooling@1.1.0.

Keeping score_docs_as_code@2.3.0 due to compatibility with score_baselibs (all released versions require 2.3.0). Upgrading to 3.0.0 causes CI failures.

wrong rebase on main

pawelrutkaq

Sorry we need to postone it until logging in in shape and works with other repos. Then I will review and recheck.

pawelrutkaq · 2026-02-24T14:51:57Z

.github/workflows/sanitizers.yml

@@ -0,0 +1,63 @@
+# *******************************************************************************


why this is seperate workflow ? isnt it something that shall run in coverage and user shall jsut have ability to enable it ? At the end, its running tests

It's not a good idea to combine coverage instrumentation with sanitizer instrumentation as they can affect each other in gcc: we may get incorrect coverage data, and maybe even get false positives in sanitizers.

pawelrutkaq · 2026-02-24T14:52:54Z

MODULE.bazel

 bazel_dep(name = "score_bazel_platforms", version = "0.0.4")
-bazel_dep(name = "score_docs_as_code", version = "2.2.0")
-bazel_dep(name = "score_tooling", version = "1.1.1")
+bazel_dep(name = "score_docs_as_code", version = "2.3.0")


wrong rebase on main

pawelrutkaq · 2026-02-24T14:53:09Z

.bazelrc

 coverage --cxxopt -runtime-counter-relocation
+
+# Dynamic analysis (sanitizers) for Linux host builds/tests.
+try-import %workspace%/quality/sanitizer/sanitizer.bazelrc


i would keep it into bazelrc for now.

pawelrutkaq · 2026-02-25T07:30:51Z

.github/workflows/sanitizers.yml

+          set -euo pipefail
+          echo "Running: bazel test --config=${{ matrix.sanitizer_config }} //tests/cpp/..."
+          # Note: Only testing C++ targets as Rust sanitizers require different configuration
+          bazel test --config=${{ matrix.sanitizer_config }} //tests/cpp/...


this is not correct target ? we shall remove contant od tests as they ment to be for cit/fit. Run correct target and let see how long it takes

@RSingh1511

Rust targets fail with C++ sanitizer flags due to linking incompatibilities

stmuench · 2026-02-25T15:47:33Z

quality/sanitizer/sanitizer.bazelrc

+test:asan_ubsan_lsan --test_env=ASAN_OPTIONS=exitcode=55:allow_addr2line=1:verbosity=1:detect_leaks=1:halt_on_error=1:allocator_may_return_null=1
+test:asan_ubsan_lsan --test_env=UBSAN_OPTIONS=exitcode=55:allow_addr2line=1:verbosity=1:print_stacktrace=1:halt_on_error=1


such env settings for sanitizers should instead come from a common place to prevent that every sub-repo configures them differently

@stmuench Good point! This aligns with @4og suggestion for a
centralized C++ policies repo (similar to https://github.com/eclipse-score/score_rust_policies)

stmuench · 2026-02-25T15:47:42Z

quality/sanitizer/sanitizer.bazelrc

+test:tsan --compilation_mode=dbg
+test:tsan --features=tsan
+test:tsan --platform_suffix=tsan
+test:tsan --test_env=TSAN_OPTIONS=exitcode=55:allow_addr2line=1:verbosity=1:halt_on_error=1:detect_deadlocks=1


RSingh1511 temporarily deployed to workflow-approval February 16, 2026 04:04 — with GitHub Actions Inactive

RSingh1511 force-pushed the rs/swp-245137 branch from 90a54e3 to 698d31d Compare February 16, 2026 04:21

RSingh1511 temporarily deployed to workflow-approval February 16, 2026 04:21 — with GitHub Actions Inactive

RSingh1511 marked this pull request as ready for review February 16, 2026 10:03

RSingh1511 requested review from antonkri, arsibo and pawelrutkaq as code owners February 16, 2026 10:03

FScholPer previously approved these changes Feb 16, 2026

View reviewed changes

MaximilianSoerenPollak reviewed Feb 16, 2026

View reviewed changes

RSingh1511 dismissed FScholPer’s stale review via 6500360 February 16, 2026 12:05

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 12:05 — with GitHub Actions Error

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 12:05 — with GitHub Actions Failure

RSingh1511 requested review from FScholPer and MaximilianSoerenPollak February 16, 2026 12:06

RSingh1511 force-pushed the rs/swp-245137 branch from 6500360 to 630e545 Compare February 16, 2026 12:41

RSingh1511 temporarily deployed to workflow-approval February 16, 2026 12:41 — with GitHub Actions Inactive

RSingh1511 force-pushed the rs/swp-245137 branch from 630e545 to a218e21 Compare February 16, 2026 13:04

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:04 — with GitHub Actions Failure

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:04 — with GitHub Actions Error

RSingh1511 force-pushed the rs/swp-245137 branch from a218e21 to f19c4ff Compare February 16, 2026 13:24

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:24 — with GitHub Actions Failure

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:24 — with GitHub Actions Error

RSingh1511 force-pushed the rs/swp-245137 branch from f19c4ff to 008bf6c Compare February 16, 2026 13:28

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:28 — with GitHub Actions Error

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:28 — with GitHub Actions Failure

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:47 — with GitHub Actions Error

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:47 — with GitHub Actions Failure

RSingh1511 temporarily deployed to workflow-approval February 16, 2026 14:06 — with GitHub Actions Inactive

RSingh1511 temporarily deployed to workflow-approval February 17, 2026 04:13 — with GitHub Actions Inactive

FScholPer previously approved these changes Feb 17, 2026

View reviewed changes

pawelrutkaq requested changes Feb 17, 2026

View reviewed changes

pawelrutkaq requested changes Feb 24, 2026

View reviewed changes

pawelrutkaq reviewed Feb 25, 2026

View reviewed changes

RSingh1511 dismissed FScholPer’s stale review via d781c59 February 25, 2026 10:33

RSingh1511 temporarily deployed to workflow-approval February 25, 2026 10:33 — with GitHub Actions Inactive

RSingh1511 added 3 commits February 25, 2026 11:44

Add sanitizer support using GCC toolchain features

db54e85

Remove TSan from CI due to kernel compatibility issues

f88cb86

Fix sanitizer workflow to test //score/... targets

1ba5d7e

RSingh1511 force-pushed the rs/swp-245137 branch from d781c59 to 1ba5d7e Compare February 25, 2026 10:45

RSingh1511 temporarily deployed to workflow-approval February 25, 2026 10:45 — with GitHub Actions Inactive

RSingh1511 requested review from 4og, FScholPer and pawelrutkaq February 25, 2026 10:47

RSingh1511 temporarily deployed to workflow-approval February 25, 2026 11:35 — with GitHub Actions Inactive

Scope sanitizer workflow to C/C++ targets only

ce8a6f7

Rust targets fail with C++ sanitizer flags due to linking incompatibilities

RSingh1511 force-pushed the rs/swp-245137 branch from 56dce0f to ce8a6f7 Compare February 25, 2026 11:37

RSingh1511 deployed to workflow-approval February 25, 2026 11:37 — with GitHub Actions Active

RSingh1511 temporarily deployed to workflow-approval February 25, 2026 11:37 — with GitHub Actions Inactive

stmuench reviewed Feb 25, 2026

View reviewed changes

		@@ -0,0 +1,63 @@
		# *******************************************************************************

		test:asan_ubsan_lsan --test_env=ASAN_OPTIONS=exitcode=55:allow_addr2line=1:verbosity=1:detect_leaks=1:halt_on_error=1:allocator_may_return_null=1
		test:asan_ubsan_lsan --test_env=UBSAN_OPTIONS=exitcode=55:allow_addr2line=1:verbosity=1:print_stacktrace=1:halt_on_error=1

Conversation

RSingh1511 commented Feb 16, 2026

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

Uh oh!

github-actions bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

MaximilianSoerenPollak Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stmuench Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Feb 16, 2026 •

edited

Loading

MaximilianSoerenPollak Feb 16, 2026 •

edited

Loading

stmuench Feb 25, 2026 •

edited

Loading